Skip to content

Conversation

@erran
Copy link
Contributor

@erran erran commented Nov 19, 2014

No description provided.

@bbatsov
Copy link
Collaborator

bbatsov commented Nov 19, 2014

Better change param to arg for consistency with the rule itself.

@erran
Copy link
Contributor Author

erran commented Nov 19, 2014

Ah, interesting cf0d2be (from #378) converted several usages of argument/arg to parameter/param. I guess in addition to one half of the anchor this rule was left as arguments.

Do not mutate arguments unless that is the purpose of the method.

Should I update the anchor/anchor link to this rule or convert it to use parameters such as the other rules updated in #378?

@erran
Copy link
Contributor Author

erran commented Nov 19, 2014

When writing a method's signature (declaring the method), the values being passed to a method are called parameters, not arguments. When calling a method, the values passed to the call are formally known as arguments. – @sethkrasnianski

With this in mind I'd say that parameters would be correct here since this rule refers to them being mutated within a method.

bbatsov added a commit that referenced this pull request Nov 26, 2014
Update the param mutation anchor
@bbatsov bbatsov merged commit e81f9d8 into rubocop:master Nov 26, 2014
@bbatsov
Copy link
Collaborator

bbatsov commented Nov 26, 2014

Fair enough.

@sethkrasnianski
Copy link
Contributor

👍

marocchino pushed a commit to marocchino/ruby-style-guide that referenced this pull request Aug 11, 2015
shyouhei pushed a commit to shyouhei/ruby-style-guide that referenced this pull request Nov 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants