Changed incorrect instances of 'arguments' to 'parameters' #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👍 |
Collaborator
|
You should also update the names of related links. |
Contributor
Author
|
Gotcha, I'll look into that shortly and update the PR later on. |
sethkrasnianski
force-pushed
the
sjk/method-verbiage
branch
2 times, most recently
from
4d6bce4 to
7af4882
Compare
Contributor
Author
|
Links are all set @bbatsov. Also amended some that I missed. All incorrect instances are accountable now. |
Contributor
Author
|
Any idea when you will be merging? No immediate rush, just wanted to understand your merging process. |
README.md
Outdated
Collaborator
There was a problem hiding this comment.
I'm not sure about this - parameters are just names and you can really modify them. You can only modify the actual arguments.
sethkrasnianski
force-pushed
the
sjk/method-verbiage
branch
from
7af4882 to
cf0d2be
Compare
Contributor
Author
|
I changed those two instances that didn't make sense back to |
bbatsov
added a commit
that referenced
this pull request
Nov 11, 2014
Changed incorrect instances of 'arguments' to 'parameters'
Collaborator
|
👍 |
marocchino
added a commit
to marocchino/ruby-style-guide
that referenced
this pull request
Dec 3, 2014
bbatsov
added a commit
that referenced
this pull request
Dec 3, 2014
Change inside of method (related #378)
marocchino
pushed a commit
to marocchino/ruby-style-guide
that referenced
this pull request
Aug 11, 2015
Changed incorrect instances of 'arguments' to 'parameters'
marocchino
added a commit
to marocchino/ruby-style-guide
that referenced
this pull request
Aug 11, 2015
marocchino
pushed a commit
to marocchino/ruby-style-guide
that referenced
this pull request
Aug 11, 2015
Change inside of method (related rubocop#378)
shyouhei
pushed a commit
to shyouhei/ruby-style-guide
that referenced
this pull request
Nov 11, 2015
Changed incorrect instances of 'arguments' to 'parameters'
shyouhei
pushed a commit
to shyouhei/ruby-style-guide
that referenced
this pull request
Nov 11, 2015
shyouhei
pushed a commit
to shyouhei/ruby-style-guide
that referenced
this pull request
Nov 11, 2015
Change inside of method (related rubocop#378)
ellimist
pushed a commit
to ellimist/ruby-style-guide
that referenced
this pull request
Mar 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing a method's signature (declaring the method), the values being passed to a method are called
parameters, notarguments. When calling a method, the values passed to the call are formally known asarguments. This is a general misnomer in the programming community. I've corrected all relevant instances.Example of parameters:
Example of arguments: