Change inside of method (related #378)

[marocchino]

No description provided.

[meagar]

👎 *args Is a common convention that I see all the time and easier to type than params

[marocchino]

I did not suggest new change. It was just fix wrong codes.
Look at the before line. def #{unsafe_method}(*params, &block).
I think it should change both line.

[bbatsov]

👍 for fixing the problem

@meagar While *args is popular indeed, some people recently expressed the desire to use the technically correct term "params" instead. Normally I use both terms interchangeably, but I do acknowledge that formally they mean different things.

[sethkrasnianski]

Looking back at this, I believe it was incorrect to merge it. The correction was not accurate. Referring to my original PR

When writing a method's signature (declaring the method), the values being passed to a method are called parameters, not arguments. When calling a method, the values passed to the call are formally known as arguments. This is a general misnomer in the programming community. I've corrected all relevant instances.

to_str.#{unsafe_method}(*params, &block)
and
find_by(prop, *params, &block)
are both calling respective methods, not declaring them.

[marocchino]

are both calling respective methods, not declaring them.

Yes, it is. But it occur NameError, when it called.

[sethkrasnianski]

sure, that may happen, but it's still a value passed to the method... right?