Skip to content

Fix buggy tests #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jdantonio merged 2 commits into from
Sep 25, 2015
Merged

Fix buggy tests #423

jdantonio merged 2 commits into from
Sep 25, 2015

Conversation

@hfenton
Copy link
Contributor

@hfenton hfenton commented Sep 25, 2015

Fixed a few buggy tests:

  • Concurrent::Agent#restart when #failed? does not clear the action queue when :clear_actions is false
  • Concurrent::Future#initialize uses the global io executor by default

@jdantonio
Copy link
Member

jdantonio commented Sep 25, 2015

The test that failed on Travis is identical to one of the tests fixed in this PR. The test that failed on AppVeyor is unrelated to this PR. I've added that test to my list on issue #318.

jdantonio added a commit that referenced this pull request Sep 25, 2015
@jdantonio
Merge pull request #423 from hfenton/fix_buggy_tests
0574881 
Fix buggy tests
@jdantonio jdantonio merged commit 0574881 into ruby-concurrency:master Sep 25, 2015
@hfenton hfenton deleted the fix_buggy_tests branch October 6, 2015 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hfenton @jdantonio