Enable ical service for London Ruby User Group#758
Merged
marcoroth merged 1 commit intoruby-conferences:mainfrom Sep 6, 2024
Merged
Enable ical service for London Ruby User Group#758marcoroth merged 1 commit intoruby-conferences:mainfrom
marcoroth merged 1 commit intoruby-conferences:mainfrom
Conversation
As of lrug/lrug.org@3ec2d10 /meetings.ics should be usable
marcoroth
reviewed
Sep 6, 2024
Collaborator
There was a problem hiding this comment.
Hey @fcheung, thanks for arranging this. I just ran it locally to test and get this:
diff --git a/_data/meetups.yml b/_data/meetups.yml
index 210dd1c..252c458 100644
--- a/_data/meetups.yml
+++ b/_data/meetups.yml
@@ -1559,10 +1559,10 @@
url: https://lu.ma/af2n3jwa
- name: London Ruby User Group - September 2024 Meeting
- location: London, UK
+ location: ''
date: 2024-09-09
- start_time: 18:00:00 BST
- end_time: 20:00:00 BST
+ start_time: 19:00:00 BST
+ end_time: 21:00:00 BST
url: https://lrug.org/meetings/2024/september
- name: 'Austin.rb - Visualizing Problems: From Abstract to Concrete'Two things:
- Can we also populate the
event.locationfield here: https://github.com/lrug/lrug.org/blob/3ec2d10a2c8bb5aebca2e7aa8664145764be80b9/lib/lrug_helpers.rb#L241? If you don't have the data it would be great if it's just aevent.location = "London, UK" - It seems like the times are off by an hour. But I haven't dug into it to see which "side" is off by one 😅
Collaborator
|
Ah, it looks like the times in the calendar are missing a timezone alltogether. It's a "18:00" in the current timezone event. I think you'd want something like: BEGIN:VEVENT
DTSTAMP:20240906T173734Z
UID:lrug-monthly-2024-09
-DTSTART:20240909T180000
+DTSTART;TZID=Europe/London:20240909T180000
-DTEND:20240909T200000
+DTSTART;TZID=Europe/London:20240909T200000
DESCRIPTION:London Ruby User Group - September 2024 Meeting\n\nHosted by: B
loom & Wild\n
SUMMARY:London Ruby User Group - September 2024 Meeting
URL;VALUE=URI:https://lrug.org/meetings/2024/september/
END:VEVENT
BEGIN:VEVENT |
Collaborator
|
Opened lrug/lrug.org#349 to address the points above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of lrug/lrug.org@3ec2d10 /meetings.ics should be usable