Skip to content

Enable ical service for London Ruby User Group#758

Merged
marcoroth merged 1 commit intoruby-conferences:mainfrom
fcheung:patch-2
Sep 6, 2024
Merged

Enable ical service for London Ruby User Group#758
marcoroth merged 1 commit intoruby-conferences:mainfrom
fcheung:patch-2

Conversation

@fcheung
Copy link
Copy Markdown
Contributor

@fcheung fcheung commented Sep 6, 2024

As of lrug/lrug.org@3ec2d10 /meetings.ics should be usable

Copy link
Copy Markdown
Collaborator

@marcoroth marcoroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @fcheung, thanks for arranging this. I just ran it locally to test and get this:

diff --git a/_data/meetups.yml b/_data/meetups.yml
index 210dd1c..252c458 100644
--- a/_data/meetups.yml
+++ b/_data/meetups.yml
@@ -1559,10 +1559,10 @@
   url: https://lu.ma/af2n3jwa
 
 - name: London Ruby User Group - September 2024 Meeting
-  location: London, UK
+  location: ''
   date: 2024-09-09
-  start_time: 18:00:00 BST
-  end_time: 20:00:00 BST
+  start_time: 19:00:00 BST
+  end_time: 21:00:00 BST
   url: https://lrug.org/meetings/2024/september
 
 - name: 'Austin.rb - Visualizing Problems: From Abstract to Concrete'

Two things:

@marcoroth
Copy link
Copy Markdown
Collaborator

marcoroth commented Sep 6, 2024

Ah, it looks like the times in the calendar are missing a timezone alltogether. It's a "18:00" in the current timezone event.

BEGIN:VEVENT
DTSTAMP:20240906T173734Z
UID:lrug-monthly-2024-09
DTSTART:20240909T180000
DTEND:20240909T200000
DESCRIPTION:London Ruby User Group - September 2024 Meeting\n\nHosted by: B
 loom & Wild\n
SUMMARY:London Ruby User Group - September 2024 Meeting
URL;VALUE=URI:https://lrug.org/meetings/2024/september/
END:VEVENT
BEGIN:VEVENT

I think you'd want something like:

BEGIN:VEVENT
DTSTAMP:20240906T173734Z
UID:lrug-monthly-2024-09
-DTSTART:20240909T180000
+DTSTART;TZID=Europe/London:20240909T180000
-DTEND:20240909T200000
+DTSTART;TZID=Europe/London:20240909T200000
DESCRIPTION:London Ruby User Group - September 2024 Meeting\n\nHosted by: B
 loom & Wild\n
SUMMARY:London Ruby User Group - September 2024 Meeting
URL;VALUE=URI:https://lrug.org/meetings/2024/september/
END:VEVENT
BEGIN:VEVENT

@marcoroth
Copy link
Copy Markdown
Collaborator

Opened lrug/lrug.org#349 to address the points above.

Copy link
Copy Markdown
Collaborator

@marcoroth marcoroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏🏼

@marcoroth marcoroth merged commit 27c8aa6 into ruby-conferences:main Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants