Repair three stale account-directory spawn fixtures - #30
Open
ruby-dlee wants to merge 1 commit into
Open
Conversation
The suite aborted at its eighth test and had been red on main for 16h, which blocked every firstmate PR behind a failure none of them caused. Three fixtures had drifted from the direct-account spawn path they model: - The fake treehouse never answered `get --lease`, so fm-spawn correctly refused to launch without a worktree. It now reports one on stdout, as treehouse does. - The fixture worktree was attached to a branch. A leased Treehouse worktree is handed over at detached HEAD, and fm-spawn refuses an attached one, so the fixture could never reach the behavior it was asserting. - The identity-drift fake detached an already-detached worktree, which is a no-op, so the post-preparation recheck had nothing to catch. It now moves the worktree onto a branch, which is a real drift. One assertion also pinned the order of two correct guards rather than the refusal itself; it now accepts either and additionally requires the refusal to name the offending path. Twelve tests go from unreachable to passing. The one remaining failure is the failed-spawn worktree leak itself, which is under repair separately. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VtDQaE3RdeuYd3aEaUvLkk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main's CI has been red for 16h on the account-directory suite, which aborted at its eighth test. Every firstmate PR inherits that failure, so #26 and #28 are both blocked by a red they did not cause.Three fixtures had drifted from the direct-account spawn path they model:
treehousenever answeredget --lease, so fm-spawn correctly refused to launch without a worktree. It now reports one on stdout, the way treehouse does.One assertion also pinned the order in which two correct guards fire rather than the refusal itself. It now accepts either and additionally requires the refusal to name the offending path, so it tests the guarantee instead of the implementation.
Twelve tests go from unreachable to passing. The one remaining failure is the failed-spawn worktree leak itself — a genuine defect, under repair separately, and not something to paper over here.