feat(crosscheck): route GLM reviews through Fireworks Fast - #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Recover and ship the exact C1 implementation produced by Azure assignment asg-00000022 before the host crash, preserving surviving commit 3c768625d25b6f87c845561b1d4208cd53327178 rather than reimplementing it. The implementation must route the Fireworks GLM 5.2 reviewer through the Fast selector accounts/fireworks/routers/glm-5p2-fast, add terminal provider/model readback checks, and include focused executable tests, while conforming to docs/azure-requirements.md and the owning Azure pilot, runner, validation, crosscheck, and workers documents and current main. Correct only actual compatibility or validation defects with executable regression evidence, and validate with focused crosscheck tests, relevant broader tests, and bin/fm-lint.sh. Ship code only: do not manufacture acceptance evidence from local tests or configuration assertions; do not start, stop, release, surrender, reset, or delete Azure resources; do not discard the retained outcome; and do not mutate or reattach the crashed C2/C3 validation run. Clearly state that C1 remains NOT ACCEPTED until this change is merged and a separate post-merge, real-provider, measured 20-to-30-minute live run satisfies the latency requirement. Never push to the default branch and never merge the PR.
What Changed
NOT ACCEPTEDuntil a separate post-merge, real-provider 20-to-30-minute live run meets the latency requirement.Risk Assessment
✅ Low: The Fast selector routing, terminal provider/model readback, historical-ledger compatibility, focused executable tests, and explicit C1 NOT ACCEPTED wording are internally consistent and well bounded.
Testing
The successful baseline was supplemented with focused host tests proving exact Fireworks Fast routing and fail-closed terminal provider/model readback, plus the Azure Crosscheck behavior suite demonstrating guest credential admission, route dispatch, and hostile/mismatched input refusal. Reviewer-visible CLI transcripts were captured; no live Azure or real-provider run was attempted, and lint was not rerun because this assigned phase expressly forbids linters.
Evidence: Host Fast-route execution transcript
Evidence: Host terminal provider/model readback transcript
Evidence: Azure Crosscheck guest behavior transcript
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
🔧 **Review** - 2 issues found → auto-fixed ✅
docs/azure-requirements.md:1077- Intent requires the change to “Clearly state that C1 remains NOT ACCEPTED,” but the rewritten acceptance section says only “NOT MET.” Preserve the required lifecycle wording explicitly, while retaining the post-merge measured-run condition.docs/configuration.md:109- The configuration guide still instructs operators to use the retired Standard selectoraccounts/fireworks/models/glm-5p2. Following it now causes reviewer preflight to refuse the roster. Update this operator-facing profile to the Fast selector introduced by the change.🔧 Fix: Align C1 status and Fast selector documentation
✅ Re-checked - no issues remain.
✅ **Test** - passed
✅ No issues found.
if [ "${FM_AZURE_VALIDATION_CELL:-0}" = 1 ]; then exec "$FM_AZURE_VALIDATION_SHARD_BRIDGE" behavior --count "${FM_AZURE_VALIDATION_SHARD_COUNT:-8}"; else exec bin/fm-no-mistakes-test-command.sh; fiConfigured baseline command (already completed successfully before this phase):if [ "${FM_AZURE_VALIDATION_CELL:-0}" = 1 ]; then exec "$FM_AZURE_VALIDATION_SHARD_BRIDGE" behavior --count "${FM_AZURE_VALIDATION_SHARD_COUNT:-8}"; else exec bin/fm-no-mistakes-test-command.sh; fiFM_TEST_CASE=test_pi_reviewer_accepts_only_successful_terminal_turn tests/fm-crosscheck.test.shFM_TEST_CASE=test_cross_family_reviewer_executes_bound_policy_profile tests/fm-crosscheck.test.shtests/fm-crosscheck-azure.test.shgit status --shortconfirmed testing left no worktree artifacts✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.