Fix type: Array + values: [...] coercing to the guessed element type instead of Array

[schinery]

guess_coerce_type's result was overwriting @coerce_type in place, so type: Array + values: [...] param coerced at runtime using the guessed element type instead of Array — rejecting valid array input and duplicating the values error on invalid input.

The guessed type is now only used locally for the existing declaration-time validate_value_coercion check, never for coerce_options.

Fixes #2812.

[github-actions]

Danger Report

No issues found.

View run

[ericproulx]

👋 @schinery I think the local guessed_coerce_type will always have the same result overtime since its value is based on previously initialized ivar and not any runtime values. Maybe we could add a @guessed_coerce_type in the initialize so we would have the original @coerce_type and the "guessed" one. Wdyt ?

[schinery]

@ericproulx yeah good point. I've added @guessed_coerce_type into the initialize so it's computed once alongside @coerce_type rather than recomputed as a local inside validate! as well as an additional spec in 888cab8

Lemme know what you think.

[ericproulx]

@ericproulx yeah good point. I've added @guessed_coerce_type into the initialize so it's computed once alongside @coerce_type rather than recomputed as a local inside validate! as well as an additional spec in 888cab8

Lemme know what you think.

Amazing!

[ericproulx]

@schinery I'll make a release this weekend.