Skip to content

🎨 Better gem_version loading#363

Merged
pboling merged 1 commit into
mainfrom
fix/gem_version_load
May 21, 2026
Merged

🎨 Better gem_version loading#363
pboling merged 1 commit into
mainfrom
fix/gem_version_load

Conversation

@pboling
Copy link
Copy Markdown
Member

@pboling pboling commented May 21, 2026

No description provided.

Copilot AI review requested due to automatic review settings May 21, 2026 09:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Ruby version check in the gemspec to use RubyGems’ Gem.ruby_version (a Gem::Version) instead of a string comparison against RUBY_VERSION, making the conditional version loading logic more robust and semantically correct.

Changes:

  • Replace RUBY_VERSION >= "3.1" string comparison with Gem.ruby_version >= Gem::Version.new("3.1") in oauth.gemspec.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pboling pboling merged commit f8afba7 into main May 21, 2026
33 checks passed
@pboling pboling deleted the fix/gem_version_load branch May 21, 2026 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants