Skip to content

Upgrade faraday to version 0.15.1 #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Upgrade faraday to version 0.15.1 #382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion oauth2.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
require 'oauth2/version'

Gem::Specification.new do |spec|
spec.add_dependency 'faraday', ['>= 0.8', '< 0.15.0']
spec.add_dependency 'faraday', ['>= 0.8', '<= 0.15.1']
Copy link

@SuperTux88 SuperTux88 May 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't do this. Use at least < 0.16.0 (as it was before) so when a new bugfix-version 0.15.2 is released you don't need to change and release a new version again.

Copy link
Member

@pboling pboling May 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a POC PR from depfu, which does a kind of Gemfile spot check upgrading, to see if the build will pass with a very specific version constraint. We won't be merging it. No worries!

Copy link

@Ch4s3 Ch4s3 May 11, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, a hard less than requirement on the current minor version is really frustrating for upstream gems that depend on oauth2. For example Sorcery depends on this gem, and anyone using that is currently blocked from using any Faraday version > 0.12.2, but there are bug fixes in 0.13 and 0.14 that are fairly important. I understand your adherence to semver, and desire not to push breaking changes, but I'm not sure it would be so terrible to relax the version requirements on Faraday.

Copy link
Member

@pboling pboling May 11, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ch4s3 @SuperTux88 This PR, or one like it, will be used as a basis to update, and possibly loosen, the faraday dependency. We are working on a new release, but all maintainers are time constrained, and none of us are in "pain" over this issue at the moment. If someone using this gem has time to switch their local dev env to their own fork, and make the changes, and validate the functionality, and push a PR that updates all the appraisal gemfiles and the gemspec, and update specs... that would be awesome.

Copy link
Contributor

@joshRpowell joshRpowell May 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pboling @Ch4s3 @SuperTux88 take a look @ #385. It works for us.

spec.add_dependency 'jwt', ['>= 1.0', '< 3.0']
spec.add_dependency 'multi_json', '~> 1.3'
spec.add_dependency 'multi_xml', '~> 0.5'
Expand Down