Upgrade faraday to version 0.15.1 #382
Conversation
|
|
||
| Gem::Specification.new do |spec| | ||
| spec.add_dependency 'faraday', ['>= 0.8', '< 0.15.0'] | ||
| spec.add_dependency 'faraday', ['>= 0.8', '<= 0.15.1'] |
There was a problem hiding this comment.
Please don't do this. Use at least < 0.16.0 (as it was before) so when a new bugfix-version 0.15.2 is released you don't need to change and release a new version again.
There was a problem hiding this comment.
This is a POC PR from depfu, which does a kind of Gemfile spot check upgrading, to see if the build will pass with a very specific version constraint. We won't be merging it. No worries!
There was a problem hiding this comment.
Yeah, a hard less than requirement on the current minor version is really frustrating for upstream gems that depend on oauth2. For example Sorcery depends on this gem, and anyone using that is currently blocked from using any Faraday version > 0.12.2, but there are bug fixes in 0.13 and 0.14 that are fairly important. I understand your adherence to semver, and desire not to push breaking changes, but I'm not sure it would be so terrible to relax the version requirements on Faraday.
There was a problem hiding this comment.
@Ch4s3 @SuperTux88 This PR, or one like it, will be used as a basis to update, and possibly loosen, the faraday dependency. We are working on a new release, but all maintainers are time constrained, and none of us are in "pain" over this issue at the moment. If someone using this gem has time to switch their local dev env to their own fork, and make the changes, and validate the functionality, and push a PR that updates all the appraisal gemfiles and the gemspec, and update specs... that would be awesome.
There was a problem hiding this comment.
@pboling @Ch4s3 @SuperTux88 take a look @ #385. It works for us.
We've upgraded a dependency and got test failures.
It looks like this version isn't compatible with your project right now. Please take a look at the exact failure to figure out if this is something you need to work on.
What changed?
✳️ faraday ( → 0.15.1) · Repo · Changelog
Release Notes
From the Github release:
Also in this release:
Commits
See the full diff on Github. The new version differs by 7 commits:
version bump to 0.15.1Fix: do not memoize/reuse Patron session (#796)Logger middleware: use $stdout instead of STDOUT (#794)Refactor: inline cached_connection (#797)Allow setting min/max ssl version for Excon (#795)NetHttpPersistent adapter better reuse of SSL connections (#793)Allow setting min/max SSL version for a Net::HTTP connection on Ruby 2.5 (#792)Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.