Upgrade rubocop to version 0.57.1 #389
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 similar comments
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've upgraded a dependency and all tests pass. \o/
You should probably take a good look at this before merging this pull request, of course.
What changed?
✳️ rubocop ( → 0.57.1) · Repo · Changelog
Release Notes
From the Github release:
Bug fixes
inherit_modedirective. (@jonas054)Layout/IndentationWidthwhen an access modifier section has an invalid indentation body. (@tatsuyafw)Layout/IndentationConsistencyshould still register an offense for private methods. (@jaredbeck)Rails/BulkChangeTable. (@wata727)Style/UnneededConditioncop accepts a case of condition andif_branchare same when usingelsifbranch. (@koic)Commits
See the full diff on Github. The new version differs by 13 commits:
Cut RuboCop 0.57.1Allow Performance/ReverseEach to add offense regardless of receiver[Fix #5380] Fix false negative in `Layout/IndentationWidth` cop (#5962)Handle properly wholly private modules in IndentationConsistency (#5909)[Fix #5958] Handle empty method body in `Rails/BulkChangeTable` (#5960)[Fix #5954] Make `Style/UnneededCondition` accepts hard write caseUpgrade rubocop-rspecUpdate rubocop_todo fileMerge pull request #5959 from jonas054/update_jaro_winkler_gemBump jaro_winkler gem to 1.5.1Merge pull request #5961 from wata727/fix_docs_for_layout_leading_blank_linesFix invalid tag format for example in Layout/LeadingBlankLinesFix unwanted warning for inherit_mode on global levelDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.