Upgrade rubocop-rspec to version 1.27.0 #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pboling
added
in Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've upgraded a dependency and all tests pass. \o/
You should probably take a good look at this before merging this pull request, of course.
What changed?
✳️ rubocop-rspec ( → 1.27.0) · Repo · Changelog
Release Notes
From the Github release:
RSpec/LeadingSubjectnow enforces subject to be before any examples, hooks or let declarations. (@Darhazer)RSpec/NotToNotto highlight only the selector (not_toorto_not), so it works also onexpect { ... }blocks. (@bquorning)RSpec/EmptyLineAfterHookcop. (@bquorning)RSpec/EmptyLineAfterExampleGroupcop to check that there is an empty line after example group blocks. (@bquorning)RSpec/DescribeClasscrashing onRSpec.describewithout arguments. (@Darhazer)RSpec/OverwritingSetupcrashing if a variable is used as an argument forlet. (@Darhazer)Commits
See the full diff on Github. The new version differs by 29 commits:
Merge pull request #640 from rubocop-hq/releaseBump version to 1.27.0Merge pull request #642 from rubocop-hq/unify-empty_line-copsUnify empty line cop logicAdd FinalEndLocation mixinMerge pull request #644 from rubocop-hq/remove-duplicate-simplecov-requirementRemove duplicate `simplecov` gem specificationMerge pull request #625 from rubocop-hq/fix-overwriting-setup-crashExtract argument name with a node matcherHandle string arguments[Fix #624] Don't check let declarations with dynamic argumentsMerge pull request #631 from rubocop-hq/fix-new-cop-generatorFix "new cop generator" rake taskMerge pull request #636 from rubocop-hq/match-dotUse location#dot instead of fixed offsetMerge pull request #626 from rubocop-hq/fix-describe-class-crash[Fix #623] Allow describe without argument and with explicit receiverMerge pull request #634 from rubocop-hq/empty-line-after-example-groupNew cop: RSpec/EmptyLineAfterExampleGroupMerge pull request #632 from rubocop-hq/empty-line-after-hookNew cop: RSpec/EmptyLineAfterHookMerge pull request #633 from rubocop-hq/improve-confirm_documentation-rake-task-errorChange error message from confirm_documentationMerge pull request #629 from rubocop-hq/not-to-not-fixHighlight selector in RSpec/NotToNotMerge pull request #627 from rubocop-hq/fix-jrubyInstall `make` on JRubyMerge pull request #619 from rubocop-hq/improve-leading-subjectMake LeadingSubject enforce subject to be above any examples or hooksDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.