🔒️ Redact sensitive values from debug logging output#707
Merged
Conversation
autobolt
force-pushed
the
feat/redact-debug-logging
branch
from
217b7a8 to
8dde2d6
Compare
- Add `OAuth2.config[:filtered_label]` to configure the placeholder used for filtered sensitive values in inspected objects and debug logging output. - Add `OAuth2.config[:filtered_debug_keys]` to configure which key names have their values redacted from debug logging output. - Add `OAuth2::ThingFilter` as the shared filtering primitive used by inspect-time and debug-log filtering. - Make inspect-time and debug-log filters snapshot their configuration at initialization time rather than tracking later config changes. - Automatically redacted values include: - Authorization headers - common token/secret fields in headers - query strings - form bodies - JSON payloads - NOTE: debug logging has always been, and remains, opt-in. It is turned off by default. Co-authored-by: autobolt <autobots@9thbit.net>
autobolt
force-pushed
the
feat/redact-debug-logging
branch
from
8dde2d6 to
594484b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OAuth2.config[:filtered_label]to configure the placeholder used for filtered sensitive values in inspected objects and debug logging output.OAuth2.config[:filtered_debug_keys]to configure which key names have their values redacted from debug logging output.OAuth2::ThingFilteras the shared filtering primitive used by inspect-time and debug-log filtering.