Fix errant subject calls in Repository specs
#50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few `subject` calls crept in where `mutable` or `dataset` should have been called instead. These references work fine where no parameters are required by the `Repository`, but don't test the object given by the caller and break for, e.g., `SPARQL::Client::Repository`.
Member
Author
|
This fixes the problem described in ruby-rdf/rdf#190 (comment) However, it looks like we have a dependency problem between the gems. |
no-reply
pushed a commit
that referenced
this pull request
Feb 2, 2016
Fix errant `subject` calls in Repository specs
Member
|
Thanks! I'm working through dependency issues now, relaxing everything to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few
subjectcalls crept in wheremutableordatasetshould havebeen called instead. These references work fine where no parameters are
required by the
Repository, but don't test the object given by thecaller and break for, e.g.,
SPARQL::Client::Repository.