fix(native_select): correct viewBox casing so the default chevron renders#467
Merged
Merged
Conversation
caaff38 to
faa4447
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The default chevron in
NativeSelectIconwas declared with a lowercaseviewbox:attribute. Phlex emits attribute keys verbatim, and SVG is case-sensitive — the browser only honorsviewBox(camelCase) and silently ignoresviewbox. With noviewBox, the0 0 24 24path renders in a raw 16px (size-4) coordinate space instead of being scaled to fit, so the chevron came out oversized / clipped.Since
NativeSelectsetsappearance-none(stripping the native arrow), this icon is the only dropdown indicator — so the glyph must render correctly.The fix is a one-character change:
viewbox:→viewBox:. The lucide chevron and all positioning classes are otherwise unchanged, keeping the component faithful to the shadcn default.Before / After (rendered HTML)
Notes
mcp/data/registry.jsonrebuilt viaexe/ruby-ui-mcp-build— the only diff is the sameviewbox→viewBoxchange in thenative_select_icon.rbentry.Tests
Full gem suite green (264 runs, 0 failures) and
standardclean locally on Ruby 3.3.3.