Skip to content

[Bug Fix] Accordion: sync docs Stimulus controller with gem #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cirdes merged 1 commit into from
Jul 28, 2026
+19 −4
Merged

[Bug Fix] Accordion: sync docs Stimulus controller with gem #490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions docs/app/javascript/controllers/ruby_ui/accordion_controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,15 @@ export default class extends Controller {

// Reveal the accordion content with animation
revealContent() {
const contentHeight = this.contentTarget.scrollHeight;
const content = this.contentTarget;

// Remove hidden so the element participates in layout before measuring
content.removeAttribute("hidden");
content.dataset.state = "open";

const contentHeight = content.scrollHeight;
animate(
this.contentTarget,
content,
{ height: `${contentHeight}px` },
{
duration: this.animationDurationValue,
Expand All @@ -78,14 +84,23 @@ export default class extends Controller {

// Hide the accordion content with animation
hideContent() {
const content = this.contentTarget;
content.dataset.state = "closed";

animate(
this.contentTarget,
content,
{ height: 0 },
{
duration: this.animationDurationValue,
easing: this.animationEasingValue,
},
);
).finished.then(() => {
// After animation completes, truly hide the element so it is removed
// from layout and form focus — prevents trapped validation errors
if (content.dataset.state === "closed") {
content.setAttribute("hidden", "");
}
});
}

// Rotate the accordion icon 180deg using animate function
Expand Down