Extend IO#tty? to recognize Windows PTYs - #139
Merged
Merged
Conversation
Allow the default tty check to be combined with platform-specific tty types.
Use Ruby-level `Module#prepend` because TruffleRuby declares but does not export `rb_prepend_module`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSYS2 and Cygwin terminals are represented by pipe handles on Windows, so the default
IO#tty?cannot recognize them as terminal devices. Provide optional terminal type arguments so callers such as Reline can detect these environments without calling Win32 APIs directly.IO#tty?andIO#isattynow accept:msys,:cygwin, and:any. Multiple types can be combined, whilenilexplicitly selects the default tty check.The no-argument behavior remains unchanged.
Tests cover ordinary PTYs, non-tty streams, multiple arguments,
nil,:any, and invalid arguments.