✨ Add SequenceSet predicates for comparing any/all/none above/below a number - #737
Merged
Conversation
nevans
changed the title
nevans
changed the title
Adds the following comparison methods to `Net::IMAP::SequenceSet` * `#all_above?`: Are all numbers in the set greater than a given number? * `#all_below?`: Are all numbers in the set less than a given number? * `#any_above?`: Are any numbers in the set greater than a given number? * `#any_below?`: Are any numbers in the set less than a given number? * `#none_above?`: Are no numbers in the set greater than a given number? * `#none_below?`: Are no numbers in the set less than a given number? These are mostly just convenience methods for checking if some number is greater than or less than `set.min` or `set.max`.
nevans
force-pushed
the
sequence_set/above_p-and-below_p
branch
from
August 27, 2026 21:29
edaacba to
a3be7cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the following comparison methods to
Net::IMAP::SequenceSet#all_above?: Are all numbers in the set greater than a given number?#all_below?: Are all numbers in the set less than a given number?#any_above?: Are any numbers in the set greater than a given number?#any_below?: Are any numbers in the set less than a given number?#none_above?: Are no numbers in the set greater than a given number?#none_below?: Are no numbers in the set less than a given number?These are mostly just convenience methods for checking if some number is greater than or less than
set.minorset.max.My primary motivation is that giving names to these simple operations helps with:
#intersect?or#disjoint?, when comparing tominormax` would be considerably faster