Fix parser translator when splatting in pattern matching pin#3529
Merged
Conversation
kddnewton
approved these changes
Mar 30, 2025
kddnewton
left a comment
kddnewton
left a comment
Collaborator
There was a problem hiding this comment.
Yes, this is definitely the correct fix. Would you mind rebasing?
Because it ends up treating it as a local variable, and `a.x` is not a valid local variable name. I'm not big on pattern matching, but conceptually it makes sense to me to treat anything inside ^() to not be pattern matching syntax?
Earlopain
force-pushed
the
parser-translator-splat-in-pin
branch
from
March 30, 2025 18:53
343584f to
80dbd85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rubocop/rubocop#14056 because it ends up treating it as a local variable, and
a.xis not a valid local variable name.I'm not big on pattern matching, but conceptually it makes sense to me to treat anything inside ^() to not be
pattern matching syntax?