Skip to content

Avoid a quadratic walk when parsing long call chains #4184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kddnewton merged 1 commit into from
Jul 28, 2026
+2 −9
Merged

Avoid a quadratic walk when parsing long call chains #4184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions src/prism.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22403,11 +22403,7 @@ parse_expression_terminator(pm_parser_t *parser, pm_node_t *node) {
// A block call (command with do-block, or any call chained
// from one) can only be followed by call chaining (., ::,
// &.), composition (and/or), and modifier operators.
if (pm_block_call_p(node)) {
return left > PM_BINDING_POWER_COMPOSITION && left < PM_BINDING_POWER_CALL;
}

return false;
return left > PM_BINDING_POWER_COMPOSITION && left < PM_BINDING_POWER_CALL && pm_block_call_p(node);
}
case PM_SUPER_NODE:
case PM_YIELD_NODE:
Expand All @@ -22419,10 +22415,7 @@ parse_expression_terminator(pm_parser_t *parser, pm_node_t *node) {

/* A super carrying a do-block is a block call, so it may also be
* followed by call chaining (`.`, `::`, `&.`). */
if (pm_block_call_p(node)) {
return left > PM_BINDING_POWER_COMPOSITION && left < PM_BINDING_POWER_CALL;
}
return false;
return left > PM_BINDING_POWER_COMPOSITION && left < PM_BINDING_POWER_CALL && pm_block_call_p(node);
case PM_DEF_NODE:
// An endless method whose body is a command-style call (e.g.,
// `def f = foo bar`) is a command assignment and can only be
Expand Down