Skip to content

Compare the missing-default sentinel by identity #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nobu merged 3 commits into from
Sep 5, 2026
Merged

Compare the missing-default sentinel by identity #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b73371
Compare the missing-default sentinel by identity
OskarEichler Aug 27, 2026
4da0037
test: cover PStore regression
OskarEichler Aug 28, 2026
40d5b23
Merge branch 'master' into codex/fetch-default-identity
nobu Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/pstore.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ def [](key)
def fetch(key, default=PStore::Error)
in_transaction
unless @table.key? key
if default == PStore::Error
if PStore::Error.equal?(default)
raise PStore::Error, format("undefined key '%s'", key)
else
return default
Expand Down
9 changes: 9 additions & 0 deletions test/test_pstore.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,4 +235,13 @@ def test_commit_targets_the_owning_store
ensure
File.unlink(second_file) rescue nil
end

def test_fetch_compares_missing_default_by_identity
default = Object.new
def default.==(_other)
true
end

assert_same(default, @pstore.transaction(true) { @pstore.fetch(:missing, default) })
end
end