Keep GC disabled during GC_test#test_stress_and_stress= - #3061
Merged
Conversation
`GC.stress = true` runs a full GC on every allocation, and each `assert_send_type` allocates heavily while parsing the method type and type checking the call trace. Since #3059 stopped `test_enable` from leaking a disabled GC into the rest of the suite, stress mode is finally live during this test, and the five assertions between `GC.stress = 0` and `GC.stress = false` turn the whole stdlib suite from 193s into 827s -- 647s of it inside this one method. The cost scales with heap size, so it is far worse in the full suite than when the file runs alone. The assertions only check the types of the return values, so no GC needs to actually run. Disable GC for the duration and restore both the stress mode and the previous enabled state afterwards. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NtDw9t8cMiaqT2s8wwSsDt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GC.stress = trueruns a full GC on every allocation andassert_send_typeallocates heavily, so now that #3059 correctly stops a disabled GC from leaking into the rest of the suite,test_stress_and_stress=takes 647s.The assertions only check the types of the return values, so disabling GC for the duration keeps stress mode inert, and the stdlib suite goes from 827s back to 184s.
🤖 Generated with Claude Code