Rename NODISCARD macro to RBS_NODISCARD - #3065
Merged
Merged
Conversation
`NODISCARD` is a generic name that can easily collide with macros defined by other headers embedding the RBS parser. Prefix it with `RBS_` to match the other public macros in `include/rbs/defines.h`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SesqemYtV3tnKoNGYuP1JW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NODISCARDis a generic name that risks colliding with macros from other headers when embedding the RBS parser.Renamed to
RBS_NODISCARDto match theRBS_prefix used by the other public macros ininclude/rbs/defines.h.Generated by Claude Code