Skip to content

Aliki: Make hamburger toggle non-selectable #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2025
Merged

Aliki: Make hamburger toggle non-selectable #1480

merged 1 commit into from
Dec 1, 2025

Conversation

@Earlopain
Copy link
Contributor

@Earlopain Earlopain commented Nov 30, 2025

It's implemented via an utf8 character but should not be selected by double-clicking

Ref #1479

@Earlopain Earlopain temporarily deployed to fork-preview-protection November 30, 2025 12:39 — with GitHub Actions Inactive
@matzbot
Copy link
Collaborator

matzbot commented Nov 30, 2025 •
edited
Loading

🚀 Preview deployment available at: https://3d1eecb4.rdoc-6cd.pages.dev (commit: 96c442b)

@st0012
Copy link
Member

st0012 commented Nov 30, 2025

I'm not sure if I misunderstood the desired behavior, but the preview site's hamburger icon is still selectable?

image

@Earlopain
Copy link
Contributor Author

Earlopain commented Nov 30, 2025

Ugh, it needs to be prefixed for some browsers. I will fix this tomorrow

@Earlopain Earlopain force-pushed the aliki-hamburger-non-selectable branch from 02b2823 to 22cffa5 Compare December 1, 2025 07:29
@Earlopain Earlopain temporarily deployed to fork-preview-protection December 1, 2025 07:29 — with GitHub Actions Inactive
@Earlopain
Copy link
Contributor Author

Earlopain commented Dec 1, 2025 •
edited
Loading

I added fallback for safari, which I guess you were using. I don't know what your browser targets are, here's the browser support: https://caniuse.com/user-select-none. Some older versions of firefox also have their own prefix but usage is very low, so probably not worth it? Same for internet explorer.

Seems like stylelint doesn't like it though?

st0012
st0012 approved these changes Dec 1, 2025
View reviewed changes
Copy link
Member

@st0012 st0012 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I appreciate the help 🙂
Can you also address the lint issue too?

If the prefix is unavoidable, let’s ignore that rule for now.

@Earlopain
Aliki: Make hamburger toggle non-selectable
96c442b 
It's implemented via an utf8 character but should
not be selected by double-clicking.

`property-no-vendor-prefix` is disabled because no autoprefixer is used
@Earlopain Earlopain force-pushed the aliki-hamburger-non-selectable branch from 22cffa5 to 96c442b Compare December 1, 2025 12:17
@Earlopain Earlopain temporarily deployed to fork-preview-protection December 1, 2025 12:17 — with GitHub Actions Inactive
@Earlopain
Copy link
Contributor Author

Earlopain commented Dec 1, 2025

If the prefix is unavoidable

Yeah, it is ( think). I guess stylelint expects you to do some postprocessing on the files so this happens automatically. I disabled the rule

@st0012 st0012 added the bug label Dec 1, 2025
@st0012 st0012 merged commit 156490d into ruby:master Dec 1, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@st0012 st0012 st0012 approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Earlopain @matzbot @st0012