Update the Minitest version to ~> 5.0 #279
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is just a little pull request that let the users relying on
RDoc::TestCaseuse a more up to date version ofMinitest. This would be very nice if this patch could be in 4.1.0. Actually Rails' documentation has an issue with chars such as
?z(see rails/rails#7172) and 4.0.1 doesn't fix this issue (see this gist) but 4.1.0.preview.3 does.Then I guess if we don't want to introduce backward incompatibilities, we could allow versions between
~> 4.0and~> 5.0and still rely onMiniTest::Unit::TestCasebut the latter will throw a deprecation warning.Let me know if you want me to add anything else to my patch.
Have a nice day.