[WIP] Support for RDoc 4+ #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the bare minimum required changes to make the generator pass without errors. Some things still not working: * Github link now showing up * Code blocks not working correctly (using Markdown) * Probably more errors
This specification is unnecessary because we already specify the version dependency in sdoc.gemspec
We were going to use this to implement RDoc::TestCase features in the MiniTest::Spec::DSL, however TestCase won't work this way and will have to reconsider another way.
Since we only have a one spec file right now, I'm just going to keep them all under ./spec
Member
Author
|
I think I'm happy with this, and would like to merge. If anyone has any objections or feedback before I merge this, I will try to do a beta release sometime by the end of next week. We still have more to do after the release as much of the code is untested and fragile. |
This was referenced Dec 21, 2013
Closed
Member
There was a problem hiding this comment.
What do you think about allowing ~> 4.0 ? All the tests are green locally with ruby/rdoc#279
By the way thanks for your work, everything seems fine on Rails' master with your branch! ❤️
Member
Author
There was a problem hiding this comment.
Maybe we could do ~> 4.0 and < 5.0
I'll work out the version dependency soon
Contributor
|
Great stuff! Let's get it merged! |
Contributor
|
I'm using this code in http://ruby-docs.org/ and so far it has been working great! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is work in progress, feel free to send patches to: https://github.com/zzak/sdoc/tree/rdoc-4