Skip to content

small idiomatic changes #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 29, 2021
Merged

small idiomatic changes #4

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
362dae3
simplify check_output
flavorjones Mar 29, 2021
262bed5
use idiomatic string interpolation
flavorjones Mar 29, 2021
ae30945
combine join and map into one line
flavorjones Mar 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions run_benchmarks.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,12 @@ def check_call(args)
end

def check_output(args)
IO.popen(args) do |pipe|
output = pipe.read
return output
end
IO.popen(args).read
end

def build_yjit(repo_dir)
if !File.exist?(repo_dir)
puts('Directory does not exist "' + repo_dir + '"')
puts("Directory does not exist \"#{repo_dir}\"")
exit(-1)
end

Expand All @@ -42,7 +39,7 @@ def build_yjit(repo_dir)
#n_cores = os.cpu_count()
n_cores = 32
puts("Building YJIT with #{n_cores} processes")
check_call(['make', '-j' + n_cores.to_s, 'install'])
check_call(["make", "-j#{n_cores}", "install"])
end
end

Expand Down Expand Up @@ -126,8 +123,7 @@ def trim_cell(cell)
end

# Row of separator dashes
sep_row = (0...num_cols).map { |i| '-' * table_data[0][i].length }
sep_row = sep_row.join(' ')
sep_row = (0...num_cols).map { |i| '-' * table_data[0][i].length }.join(' ')

out = sep_row + "\n"

Expand Down