small idiomatic changes #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks Mike! |
byroot
added a commit
to byroot/yjit-bench
that referenced
this pull request
Jan 29, 2025
THe initial snapshot was from a few years back, the application changed a lot since then. I had to run a bunch of migrations and had to fiddle with various sqlite3/msyql incompatibilities. Also some route changes, but with a bit of effort I managed to make it work again. What is interesting is it seems lobste.rs became 2-3-x as slow in these couple years, I haven't yet profiled to know why. This branch: ``` itr: time ruby#1: 1532ms ruby#2: 1013ms ruby#3: 910ms ruby#4: 852ms ruby#5: 851ms ruby#6: 901ms ruby#7: 857ms ruby#8: 886ms ruby#9: 875ms ``` main: ``` itr: time ruby#1: 884ms ruby#2: 482ms ruby#3: 344ms ruby#4: 358ms ruby#5: 300ms ruby#6: 316ms ruby#7: 315ms ruby#8: 328ms ruby#9: 309ms ```
byroot
added a commit
to byroot/yjit-bench
that referenced
this pull request
Jan 30, 2025
THe initial snapshot was from a few years back, the application changed a lot since then. I had to run a bunch of migrations and had to fiddle with various sqlite3/msyql incompatibilities. Also some route changes, but with a bit of effort I managed to make it work again. What is interesting is it seems lobste.rs became 2-3-x as slow in these couple years, I haven't yet profiled to know why. This branch: ``` itr: time ruby#1: 1532ms ruby#2: 1013ms ruby#3: 910ms ruby#4: 852ms ruby#5: 851ms ruby#6: 901ms ruby#7: 857ms ruby#8: 886ms ruby#9: 875ms ``` main: ``` itr: time ruby#1: 884ms ruby#2: 482ms ruby#3: 344ms ruby#4: 358ms ruby#5: 300ms ruby#6: 316ms ruby#7: 315ms ruby#8: 328ms ruby#9: 309ms ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.