[Bug #21513] Raise on converting endless range to set#13902
Merged
knu merged 1 commit intoruby:masterfrom Jul 29, 2025
Merged
Conversation
jeremyevans
requested changes
Jul 15, 2025
Contributor
jeremyevans
left a comment
jeremyevans
left a comment
There was a problem hiding this comment.
Thank you for working on this.
viralpraxis
force-pushed
the
raise-on-endless-range-to-set
branch
2 times, most recently
from
4b9f122 to
31a3861
Compare
Contributor
Author
|
There's a SEGV in the ZJIT test suite: https://github.com/ruby/ruby/actions/runs/16305765996/job/46051383888?pr=13902 Not sure if it's related to my changes |
viralpraxis
force-pushed
the
raise-on-endless-range-to-set
branch
from
31a3861 to
a5a7db6
Compare
Contributor
ZJIT error seems entirely unrelated to your change from a quick glance |
Contributor
|
Looks like a weird GC issue related to marking though so paging in @k0kubun for good measure |
nobu
reviewed
Jul 15, 2025
viralpraxis
force-pushed
the
raise-on-endless-range-to-set
branch
from
a5a7db6 to
e1b6f53
Compare
viralpraxis
changed the title
viralpraxis
force-pushed
the
raise-on-endless-range-to-set
branch
from
e1b6f53 to
ca35402
Compare
This comment has been minimized.
This comment has been minimized.
Member
|
I agree that it's probably not related to the changes. We're looking into GC issues with ZJIT. |
viralpraxis
force-pushed
the
raise-on-endless-range-to-set
branch
6 times, most recently
from
7753557 to
2de1bf0
Compare
Contributor
Author
|
Could someone please take a look? |
viralpraxis
force-pushed
the
raise-on-endless-range-to-set
branch
from
2de1bf0 to
36e3cee
Compare
jeremyevans
requested changes
Jul 24, 2025
viralpraxis
force-pushed
the
raise-on-endless-range-to-set
branch
from
36e3cee to
f9dce06
Compare
jeremyevans
approved these changes
Jul 24, 2025
Contributor
Author
|
@jeremyevans thank you very much for helping me with that! ❤️ |
viralpraxis
force-pushed
the
raise-on-endless-range-to-set
branch
2 times, most recently
from
77d1e01 to
2241e74
Compare
Contributor
Author
|
CI failures are unrelated: TestGemRequest#test_verify_certificate_extra_message:
Test::Unit::ProxyError: X509_dup
/home/runner/work/ruby/ruby/src/lib/rubygems/request.rb:92:in 'OpenSSL::X509::StoreContext#current_cert'
/home/runner/work/ruby/ruby/src/lib/rubygems/request.rb:92:in 'Gem::Request.verify_certificate'
/home/runner/work/ruby/ruby/src/test/rubygems/test_gem_request.rb:373:in 'block in TestGemRequest#test_verify_certificate_extra_message'
/home/runner/work/ruby/ruby/src/lib/rubygems/user_interaction.rb:46:in 'Gem::DefaultUserInteraction.use_ui'
/home/runner/work/ruby/ruby/src/lib/rubygems/user_interaction.rb:69:in 'Gem::DefaultUserInteraction#use_ui'
/home/runner/work/ruby/ruby/src/test/rubygems/test_gem_request.rb:372:in 'TestGemRequest#test_verify_certificate_extra_message' |
ref: https://bugs.ruby-lang.org/issues/21513 Before this patch, trying to convert endless range (e.g. `(1..)`) to set (using `to_set`) would hang
viralpraxis
force-pushed
the
raise-on-endless-range-to-set
branch
from
2241e74 to
d8acf88
Compare
knu
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this patch, trying to convert endless range (e.g.
(1..)or any other inifinte enumerable) to set (usingto_set) would hang