Make test-bundled-gems.rb detect test failure propery even when child process timed out on Windows#14695
Draft
YO4 wants to merge 1 commit intoruby:masterfrom
Draft
Make test-bundled-gems.rb detect test failure propery even when child process timed out on Windows#14695YO4 wants to merge 1 commit intoruby:masterfrom
YO4 wants to merge 1 commit intoruby:masterfrom
Conversation
The child process killed by SIGKILL returns 0 on Windows
❌ 1/62390 Tests Failedfile=test/ruby/test_gc.rb#class=TestGc#testcase=test_thrashing_for_young_objects |
Contributor
Author
|
Additional context refering this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I posted new PR #14718 and I think that PR supersedes this.
test-bundled-gems.rb terminates child process with
Process.kill("KILL", pid)if that timed out on Windows.Unfortunately, child process exits with 0 in that case, test-bundled-gems.rb misses to detect failure.
This PR changes process termination method to
system("taskkill /F /PID #{pid}")and child process is turned into exiting with 1.Changing the behavior of Process::kill is also a possible option, but it is not addressed in this PR.