ZJIT: Inline struct aref #15008
ZJIT: Inline struct aref #15008
Conversation
tekknolagi
force-pushed
the
mb-opt-struct-aref
branch
from
a5abdd5 to
7e50aca
Compare
struct.c
Outdated
| } | ||
|
|
||
| bool | ||
| rb_yarv_struct_instances_embedded_p(VALUE klass) |
There was a problem hiding this comment.
I'm not sure this is the best way to do this. YJIT does it by inspecting an instance, which we don't have. Maybe we could add it to profiles? :/
There was a problem hiding this comment.
Can't you use recv_type.flags().is_embedded()?
EDIT: nevermind it's a different bit for structs than T_OBJECTs.
There was a problem hiding this comment.
Oh. I thought that was only for ivars. If not then yes we can absolutely do that
There was a problem hiding this comment.
I am adding a new bit
zjit/src/hir.rs
Outdated
| .try_into() | ||
| .unwrap(); | ||
| // Confidence checks | ||
| // assert!(unsafe { RB_TYPE_P(recv, RUBY_T_STRUCT) }); |
There was a problem hiding this comment.
I would like to figure out a way to keep these kinds of checks in ZJIT
struct.c
Outdated
| } | ||
|
|
||
| bool | ||
| rb_yarv_struct_instances_embedded_p(VALUE klass) |
There was a problem hiding this comment.
Can't you use recv_type.flags().is_embedded()?
EDIT: nevermind it's a different bit for structs than T_OBJECTs.
tekknolagi
force-pushed
the
mb-opt-struct-aref
branch
from
7e50aca to
b252afc
Compare
3 participants
Per #15002, this happens frequently in benchmarks.