Merged
Conversation
Member
hsbt
commented
Jan 19, 2026
[PATCH] search_nonascii(): Replace UB pointer cast with memcpy Casting a pointer to create an unaligned one is undefined behavior in C standards. Use memcpy to express the unaligned load instead to play by the rules. Practically, this yields the same binary output in many situations while fixing the crash in [Bug #21715].
There was a problem hiding this comment.
Pull request overview
This PR backports a fix for Bug #21715 to Ruby 3.4, addressing undefined behavior in the search_nonascii() function. The issue involved casting pointers to create unaligned pointers, which is undefined behavior in C. The fix replaces unsafe pointer casting with memcpy to safely handle unaligned loads.
Changes:
- Incremented the Ruby patchlevel from 72 to 73
- Refactored
search_nonascii()to use char pointer iteration with memcpy instead of uintptr_t pointer dereferencing - Eliminated undefined behavior while maintaining functionally equivalent code
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| version.h | Incremented RUBY_PATCHLEVEL from 72 to 73 for the bug fix release |
| string.c | Replaced unsafe unaligned pointer casts with memcpy-based loads in search_nonascii() function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.