Run GC if fiber pool expansion fails.#16535
Merged
ioquatix merged 3 commits intoruby:masterfrom Mar 26, 2026
Merged
Conversation
337e10c to
5397956
Compare
This comment has been minimized.
This comment has been minimized.
7e61a36 to
8e4a9f5
Compare
Member
|
I confirmed the failure path works on Linux. |
a1395e5 to
fb42b3d
Compare
5a4208b to
e3b2b83
Compare
There was a problem hiding this comment.
Pull request overview
This PR addresses Bug #21964 by making fiber stack acquisition more resilient when the fiber pool cannot be expanded (e.g., due to VMA/map limits), triggering a GC + retry before ultimately raising.
Changes:
- Refactors
fiber_pool_expandto returnNULL(witherrno) on failure instead of raising immediately, allowing callers to decide recovery behavior. - Adds a slow-path in
fiber_pool_stack_acquireto runrb_gc()and retry pool expansion when expansion fails. - Adds a regression test intended to exercise fiber creation under
vm.max_map_countpressure.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
cont.c |
Changes fiber pool expansion/acquisition flow to GC+retry on expansion failure and adjusts error handling paths. |
test/ruby/test_fiber.rb |
Adds a regression test to ensure fiber creation doesn’t raise when pool expansion hits mapping limits. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f1b938f to
d15d96d
Compare
7bbb99e to
8efedc5
Compare
ioquatix
reviewed
Mar 26, 2026
746d84f to
2576c62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug #21964