Use nprocessors as default_max_cpu for M:N scheduler#17100
Merged
nobu merged 3 commits intoJun 6, 2026
Conversation
Resolves the `TODO: CPU num?`. Uses `sysconf(_SC_NPROCESSORS_ONLN)` with a fallback to 8, guarded by `#if defined(HAVE_SYSCONF) && defined(_SC_NPROCESSORS_ONLN)`.
…NLN) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
thekuwayama
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
This PR proposes to remove the hardcoded
default_max_cpuvalue.Instead,
default_max_cpuwill be initialized using the value returned bysysconf(_SC_NPROCESSORS_ONLN).default_max_cpuhas a default value that is hardcoded to 8, with aTODO: CPU num?comment. This PRdefault_max_cputo the value returned bysysconf(_SC_NPROCESSORS_ONLN)_SC_NPROCESSORS_ONLNis unavailableIf you intentionally (temporarily) hardcoded it to 8, please close this pull request.