Skip to content

Conversation

@hsbt
Copy link
Member

@hsbt hsbt commented Sep 1, 2020

Bundle RBS gem

@hsbt hsbt marked this pull request as ready for review September 1, 2020 12:10
@hsbt
Copy link
Member Author

hsbt commented Sep 1, 2020

@soutaro This PR added rbs as the bundled gems for Ruby 3. But the current status of make test-bundled-gems are:

234 tests, 4913 assertions, 11 failures, 2 errors, 0 skips

They caused by racc command in test suite. We should ignore on rbs repository or racc command provided by ruby/ruby repo with non-installed ruby interpreter.

@hsbt
Copy link
Member Author

hsbt commented Sep 16, 2020

Maybe, We need to fix #3551 before merging this.

@mrkn
Copy link
Member

mrkn commented Sep 16, 2020

I merged #3551.

@soutaro soutaro merged commit ba88910 into ruby:master Sep 23, 2020
@hsbt hsbt deleted the bundle-rbs branch September 23, 2020 02:07
ioquatix pushed a commit to ioquatix/ruby that referenced this pull request Sep 30, 2020
* Added rbs as bundled gems
* Added the missing dependencies for rbs gem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants