Backport to support macOS Ventura and Xcode 14 for Ruby 3.0#6441
Merged
unak merged 3 commits intoruby:ruby_3_0from Oct 1, 2022
hsbt:backport-ventura-xcode14-3-0
Merged
Backport to support macOS Ventura and Xcode 14 for Ruby 3.0#6441unak merged 3 commits intoruby:ruby_3_0from hsbt:backport-ventura-xcode14-3-0
unak merged 3 commits intoruby:ruby_3_0from
hsbt:backport-ventura-xcode14-3-0
Conversation
Member
hsbt
commented
Sep 26, 2022
hsbt
commented
- https://bugs.ruby-lang.org/issues/18912
- https://bugs.ruby-lang.org/issues/19005
The warning against `-undefined dynamic_lookup` is just a warning yet, and many gems seem to pay no attention to warnings. Until it fails actually, keep it as a migration path, except for standard extension libraries and bundled extension gems.
Since macOS 13, CFString family API used in `rb_str_append_normalized_ospath` may internally use Objective-C classes (`NSTaggedPointerString` and `NSPlaceholderMutableString`) for small strings. On the other hand, Objective-C classes should not be used for the first time in a `fork()`'ed but not `exec()`'ed process. Violations for this rule can result deadlock during class initialization, so Objective-C runtime conservatively crashes on such cases by default. Therefore, we need to use CFString API to initialize Objective-C classes used internally *before* `fork()`. For more details, see https://bugs.ruby-lang.org/issues/18912
Member
Author
Member
Author
|
Note: nobu said "LGTM" |
unak
approved these changes
Oct 1, 2022
avmnu-sng
reviewed
Dec 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.