Skip to content

[YARP] Avoid if-else in yp_compile_node #8336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jemmaissroff merged 1 commit into from
Aug 31, 2023
Merged

[YARP] Avoid if-else in yp_compile_node #8336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions yarp/yarp_compiler.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1286,14 +1286,10 @@ yp_compile_node(rb_iseq_t *iseq, const yp_node_t *node, LINK_ANCHOR *const ret,
case YP_NODE_STATEMENTS_NODE: {
yp_statements_node_t *statements_node = (yp_statements_node_t *) node;
yp_node_list_t node_list = statements_node->body;
for (size_t index = 0; index < node_list.size; index++) {
if (!popped && (index != node_list.size - 1)) {
yp_compile_node(iseq, node_list.nodes[index], ret, src, true, compile_context);
}
else {
yp_compile_node(iseq, node_list.nodes[index], ret, src, false, compile_context);
}
for (size_t index = 0; index < node_list.size - 1; index++) {
yp_compile_node(iseq, node_list.nodes[index], ret, src, !popped, compile_context);
}
yp_compile_node(iseq, node_list.nodes[node_list.size - 1], ret, src, false, compile_context);
return;
}
case YP_NODE_STRING_CONCAT_NODE: {
Expand Down