Skip to content

[DOC] Fix platform-dependent directives and modifiers#8601

Merged
matzbot merged 1 commit intoruby:masterfrom
nobu:pack
Oct 6, 2023
Merged

[DOC] Fix platform-dependent directives and modifiers#8601
matzbot merged 1 commit intoruby:masterfrom
nobu:pack

Conversation

@nobu
Copy link
Copy Markdown
Member

@nobu nobu commented Oct 6, 2023

  • 'j' and 'J' are not pointer directives.
  • size of 'j' and 'J' are platform-dependent, may not be 64-bit.
  • mention corresponding C types when native-size modifier is added.

@nobu nobu added the Documentation Improvements to documentation. label Oct 6, 2023
@nobu nobu requested a review from BurdetteLamar October 6, 2023 10:04
@BurdetteLamar
Copy link
Copy Markdown
Member

@nobu, I don't feel qualified to review this.

@nobu
Copy link
Copy Markdown
Member Author

nobu commented Oct 6, 2023

@BurdetteLamar It’s ok even for wording etc.

Comment thread doc/packed_data.rdoc Outdated

- <tt>'j'</tt> - 64-bit pointer-width signed integer,
native-endian (like C <tt>intptr_t</tt>):
- <tt>'j'</tt> - pointer-width signed integer, native-endian
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Pointer-width' (capital P).

* 'j' and 'J' are not pointer directives.
* size of 'j' and 'J' are platform-dependent, may not be 64-bit.
* mention corresponding C types when native-size modifier is added.

Co-Authored-By: BurdetteLamar <burdettelamar@yahoo.com>
@matzbot matzbot merged commit 7b8d472 into ruby:master Oct 6, 2023
@nobu nobu deleted the pack branch October 7, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements to documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants