Skip to content

"+MN" in description#8682

Merged
ko1 merged 1 commit intoruby:masterfrom
ko1:mn_threads_description
Oct 17, 2023
Merged

"+MN" in description#8682
ko1 merged 1 commit intoruby:masterfrom
ko1:mn_threads_description

Conversation

@ko1
Copy link
Copy Markdown
Contributor

@ko1 ko1 commented Oct 17, 2023

If RUBY_MN_THREADS=1 is given, this patch shows +MN in RUBY_DESCRIPTION like:

$ RUBY_MN_THREADS=1 ./miniruby  --yjit -v
ruby 3.3.0dev (2023-10-17T04:10:14Z master 908f8fffa2) +YJIT +MN [x86_64-linux]

Before this patch, a warning is displayed if $VERBOSE is given. However it can make troubles with tests (with $VERBOSE), do not show any warning with a MN threads configuration.

If `RUBY_MN_THREADS=1` is given, this patch shows `+MN` in
`RUBY_DESCRIPTION` like:

```
$ RUBY_MN_THREADS=1 ./miniruby  --yjit -v
ruby 3.3.0dev (2023-10-17T04:10:14Z master 908f8ff) +YJIT +MN [x86_64-linux]
```

Before this patch, a warning is displayed if `$VERBOSE` is given.
However it can make troubles with tests (with `$VERBOSE`), do not
show any warning with a MN threads configuration.
@ko1 ko1 marked this pull request as ready for review October 17, 2023 07:00
@ko1 ko1 merged commit c9990c8 into ruby:master Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant