Improve duplicate key warning. #938
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your message adds "clobber" which isn't used anywhere else in the core library. I think we should avoid adding new words in errors and warnings to make ruby easier to use for non-english speakers. What about |
|
Agreed, although I'd also like to convey that it overwrites the previous value. |
This change rephrases the duplicate key warning from this: ``` /Users/andre/bug.rb:4: warning: duplicated key at line 5 ignored: :max_instances ``` which causes some confusion, to: ``` /Users/andre/bug.rb:4: warning: key :max_instances is duplicated and overwritten on line 5 ```
|
Alright, changed it so that it informs that the key is duplicated AND that it gets overwritten. |
|
I like the updated message. |
|
|
😄
|
I ❤️ this change. I've recently seen this warning and had to read it a few times to decipher it. The new warning is easier for me to understand. |
nurse
pushed a commit
to nurse/ruby
that referenced
this pull request
Sep 18, 2015
[Fix rubyGH-938] ruby#938 [Bug ruby#11327] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51196 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change rephrases the duplicate key warning from this:
which causes some confusion, to:
/cc @ko1 @tenderlove @rafaelfranca