Remove dartsass-rails and importmap-rails - #651
Merged
Conversation
The stylesheet only used trivial Sass features, so it can be plain CSS served directly by propshaft. This removes the dartsass build step and the platform-specific sass-embedded binaries. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
min-height: 0.01% (IE9) and -ms-overflow-style (IE10/11) no longer serve any browser, and overflow-x: auto is already defined by Bootstrap 5. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Uses :nth-child(n+6):where(:nth-child(-n+9)). The :where() keeps specificity at the original 0-1-1 so the later td.summary rules still override the range for the summary column. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
application.js initialized jQuery-based tooltips and popovers, but jQuery is not loaded and no view has matching elements, so every page ran no JavaScript at all. Dropping it removes the importmap-rails gem and the runtime dependency on the ga.jspm.io CDN. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The dump was a side effect of a local sqlite db:prepare in an unrelated commit, not a deliberate schema update. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
application.scssonly used trivial Sass features, so I converted it to plain CSS served directly by propshaft and droppeddartsass-rails, removing the build step and the platform-specificsass-embeddedbinaries.bootstrap.min.cssis now linked separately in the layout.importmap-railsturned out to load only dead code.application.jsinitializes jQuery-based tooltips and popovers, but jQuery is not loaded and no view has matching elements, so pages ran no JavaScript at all. Removing it also drops the runtime dependency on thega.jspm.ioCDN.The conversion also drops IE-era workarounds and rules duplicated by Bootstrap 5. I verified
assets:precompileand page rendering with both stylesheets and zero script tags.Generated with Claude Code