Skip to content

Prepare rubygems 3.3.10 and bundler 2.3.10#5420

Merged
deivid-rodriguez merged 10 commits into3.3from
release/bundler_2.3.10_rubygems_3.3.10
Mar 23, 2022
Merged

Prepare rubygems 3.3.10 and bundler 2.3.10#5420
deivid-rodriguez merged 10 commits into3.3from
release/bundler_2.3.10_rubygems_3.3.10

Conversation

@deivid-rodriguez
Copy link
Copy Markdown
Contributor

It's release day!

@simi two questions. Cool with releasing #5175 now, right? Also, may I also sneak #5416 into the release?

simi and others added 4 commits March 23, 2022 11:25
Remove extra closing bracket in version warning

(cherry picked from commit 9aeff4e)
Unhide RDoc documentation from top level `Gem` module

(cherry picked from commit 9825d7f)
Report Github Actions CI provider within user agent string

(cherry picked from commit 2dcdc8d)
[DOC] Enable Gem::Package example

(cherry picked from commit bc34434)
@simi
Copy link
Copy Markdown

simi commented Mar 23, 2022

I'm ok to release #5175, but I would not promote it for now unless bundler gem integration is done, which is going to introduce Rust extension gem structure. The gem structure in tests (which is the only reference implementation I'm aware of) is currently simplified and it will be changed as well in the bundler gem integration to follow the structure.

@deivid-rodriguez
Copy link
Copy Markdown
Contributor Author

I see, so we can release it without a changelog entry? I think there's no rush to ship it, so we can also just delay it a little bit until we can tweak the bundle gem generated skeleton. What do you think?

@simi
Copy link
Copy Markdown

simi commented Mar 23, 2022

I see, so we can release it without a changelog entry? I think there's no rush to ship it, so we can also just delay it a little bit until we can tweak the bundle gem generated skeleton. What do you think?

I suggest to just don't promote it in blog posts and usual stuff. I'll ensure everything is prepared for Ruby 3.2 release.

@deivid-rodriguez
Copy link
Copy Markdown
Contributor Author

Oh, ok, so we release it normally but don't further promote it for now 👍.

@deivid-rodriguez
Copy link
Copy Markdown
Contributor Author

Actually, the ruby-core job seems broken due to #5175. Mind skipping it for this release and I'll work on making it green for 3.3.11?

@simi
Copy link
Copy Markdown

simi commented Mar 23, 2022

Feel free to skip it for now if needed.

Btw. @hsbt planned to include it into Ruby 3.2.preview1 if I remember well. We need to fix the problems anyway soon.

@deivid-rodriguez
Copy link
Copy Markdown
Contributor Author

Yes, I will address it for next release. But I think it won't block 3.2.preview1 anyways, because this issue seems specific to our stable branch, and I think 3.2.preview1 is cut from Ruby's master branch, which seems fine.

More helpful reporting of marshal loading issues

(cherry picked from commit c7adc54)
@simi
Copy link
Copy Markdown

simi commented Mar 23, 2022

There are some troubles already AFAIK - ruby/ruby#5669.

@deivid-rodriguez deivid-rodriguez force-pushed the release/bundler_2.3.10_rubygems_3.3.10 branch from 080113a to 813b4ab Compare March 23, 2022 14:45
@deivid-rodriguez
Copy link
Copy Markdown
Contributor Author

Oh, I thought it had been incorporated already. Ok, great, I'm subscribing to that ticket and will be skipping for this release and aim for the next.

@deivid-rodriguez deivid-rodriguez marked this pull request as ready for review March 23, 2022 16:15
@deivid-rodriguez deivid-rodriguez force-pushed the release/bundler_2.3.10_rubygems_3.3.10 branch 2 times, most recently from 5c3df43 to 1fc1f31 Compare March 23, 2022 16:26
@deivid-rodriguez deivid-rodriguez force-pushed the release/bundler_2.3.10_rubygems_3.3.10 branch from 1fc1f31 to 2e47af6 Compare March 23, 2022 17:46
@deivid-rodriguez deivid-rodriguez merged commit 4bbb70e into 3.3 Mar 23, 2022
@deivid-rodriguez deivid-rodriguez deleted the release/bundler_2.3.10_rubygems_3.3.10 branch March 23, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants