Add --cooldown flag to bundle lock and bundle cache - #9725
Merged
Conversation
Both commands resolve, but only install, update, add and outdated accepted the flag, so the resolver's failure hint suggesting `--cooldown 0` was not actionable on `bundle lock --update`. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Exclusion is keyed on [name, version] and deliberately ignores platform, so pushing a fresh platform-specific build under an already-ripe version number cannot slip new code past the cooldown. No spec covered that behavior. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
On x86_64-linux hosts `--cooldown 0` resolves to the platform-specific build, so `include_gems` failed expecting the ruby platform. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bundle lockandbundle cacheboth resolve, but neither accepted--cooldown, so the resolver's failure hint suggesting--cooldown 0was not actionable onbundle lock --update. This adds the flag to both commands with the same validation and settings propagation asbundle install, and documents it inbundle-lock(1)andbundle-cache(1).bundle cacheresolves throughbundle installinternally, so the flag applies on both paths.A second commit pins existing resolver behavior in an e2e spec. Cooldown exclusion is keyed on gem name and version ignoring platform, so a fresh platform-specific build pushed under an already-ripe version number cannot slip past the cooldown.
Generated with Claude Code