Warn when duplicate source declarations conflict on cooldown - #9736
Merged
Conversation
Declaring the same source URL twice with different cooldown values silently drops one of them, because duplicate declarations are deduped into a single source and cooldown applies per server, not per gem. The reporter of #9723 used a second source block with cooldown: 0 as a per-gem exemption and got no indication it had no effect. Keep the dedup behavior but warn when a conflicting cooldown value is discarded. #9723 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #9723. Declaring the same source URL twice with different
cooldown:values silently drops one of them. Duplicate declarations are deduped into a single source, and cooldown applies per server, not per gem. The reporter of #9723 used a second source block withcooldown: 0as a per-gem exemption and got no indication it had no effect.This keeps the dedup behavior unchanged and warns when a conflicting cooldown value is discarded. Duplicate declarations with the same value or without a
cooldown:option stay silent.