Don't mask install errors when no Gemfile can be located - #9757
Merged
Conversation
require_tree_for_spec calls SharedHelpers.default_gemfile to build the "In Gemfile:" header of the error report. When BUNDLE_GEMFILE is unset and no Gemfile is findable from the current directory, that raises GemfileNotFound from inside the error-reporting path, hiding the original install errors behind "Could not locate Gemfile". Fall back to a generic header so the real errors always surface. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParallelInstaller#require_tree_for_speccallsSharedHelpers.default_gemfileto build theIn Gemfile:header of the install error report. WhenBUNDLE_GEMFILEis unset and no Gemfile is findable from the current directory, for example when Bundler is used as a library, this raisesGemfileNotFoundfrom inside the error-reporting path and the original install errors get replaced by "Could not locate Gemfile". Fall back to a generic header so the real errors always surface.