install specific bundler version when minor and patch versions are defined#139
Merged
eregon merged 1 commit intoruby:masterfrom Jan 7, 2021
Merged
Conversation
manuelmeurer
force-pushed
the
install-specific-bundler-version
branch
from
3b97b10 to
48a3a35
Compare
Contributor
Author
|
@eregon Are those failures relevant to my change? |
eregon
reviewed
Jan 6, 2021
Member
eregon
left a comment
eregon
left a comment
There was a problem hiding this comment.
Looks great, just one small refinement.
| } else { | ||
| const gem = path.join(rubyPrefix, 'bin', 'gem') | ||
| await exec.exec(gem, ['install', 'bundler', '-v', `~> ${bundlerVersion}`, '--no-document']) | ||
| const bundlerVersionConstraint = bundlerVersion.match(/^\d+\.\d+\.\d+$/) ? bundlerVersion : `~> ${bundlerVersion}` |
Member
There was a problem hiding this comment.
I think we should remove the $ here so e.g. 2.2.0.rc.2 would also be considered an exact version.
(https://rubygems.org/gems/bundler/versions)
Member
Not caused by your change, it's a known issue, it's being worked on. |
install specific bundler version when minor and patch versions are defined
manuelmeurer
force-pushed
the
install-specific-bundler-version
branch
from
48a3a35 to
710f684
Compare
eregon
approved these changes
Jan 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #138