Read the Pagefind entry as UTF-8 - #3992
Merged
Merged
Conversation
Pagefind lists the word characters it splits on in `include_characters`, and they reach past ASCII. On a build host that leaves the locale at POSIX, Cloudflare Pages among them, `File.read` hands back a US-ASCII string and the build dies in `JSON.parse` on the first of those bytes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloudflare Pages has failed every build since #3989 merged.
Pagefind lists the word characters it splits on in
include_characters, sopagefind-entry.jsonreaches past ASCII.read_entryused a bareFile.read, which tags the string withEncoding.default_external. Cloudflare's build container leaves the locale at POSIX, so that is US-ASCII andJSON.parseraises as it converts the source to UTF-8. GitHub Actions sets a UTF-8 locale, which is why CI stayed green.The fixture now carries
include_charactersthe way Pagefind writes it, and one case runsapply_fallbacksunder a US-ASCIIEncoding.default_external.