Skip to content

Update Installation (ko) #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 11, 2014
Merged

Update Installation (ko) #913

merged 6 commits into from
Dec 11, 2014

Conversation

@marocchino
Copy link
Member

@marocchino marocchino commented Dec 8, 2014

No description provided.

@marocchino
Copy link
Member Author

marocchino commented Dec 8, 2014

@namsk review please. 🐱

namsk
namsk reviewed Dec 9, 2014
View reviewed changes
ko/installation/index.md Outdated
Copy link
Contributor

@namsk namsk Dec 9, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

운영체재 -> 운영체제

Copy link
Member Author

@marocchino marocchino Dec 9, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix in 3c32c02

@stomar
Copy link
Contributor

stomar commented Dec 9, 2014

@marocchino
You need to base your PR from current master, the file has been moved. And there will probably be another small change later today, so you might want to wait until then.

@marocchino
Copy link
Member Author

marocchino commented Dec 9, 2014

@stmar We are in different timezone. so, "Today" is not that clear to us. can you ping me its over?

@stomar
Copy link
Contributor

stomar commented Dec 9, 2014

ping 😄

Note also the related changes to documentation and quickstart.

@marocchino
Copy link
Member Author

marocchino commented Dec 9, 2014

@stmar Thank you! 😄
@namsk It is done. Can you review again?

namsk
namsk reviewed Dec 10, 2014
View reviewed changes
ko/documentation/index.md Outdated
Copy link
Contributor

@namsk namsk Dec 10, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a space between '원서들은' and '[여기]'.

Copy link
Member Author

@marocchino marocchino Dec 10, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix in 02f77f1

namsk added a commit that referenced this pull request Dec 11, 2014
@namsk
Merge pull request #913 from marocchino/ko-install
f3f897f 
Update Installation (ko)
@namsk namsk merged commit f3f897f into ruby:master Dec 11, 2014
@namsk
Copy link
Contributor

namsk commented Dec 11, 2014

Thanks @marocchino

@marocchino marocchino deleted the ko-install branch December 11, 2014 11:13
@JuanitoFatas JuanitoFatas mentioned this pull request May 26, 2015
Closed
44 tasks
@hlcfan hlcfan mentioned this pull request Oct 19, 2015
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marocchino @stomar @namsk