Skip to content

remove now-unused rubocop-packs dependency #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
technicalpickles merged 4 commits into from
Sep 20, 2023
Merged

remove now-unused rubocop-packs dependency #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d9ce51
try removing require of rubocop-packs
technicalpickles Aug 31, 2023
f3c176c
remove dependency and rbi
technicalpickles Sep 6, 2023
8452bca
Merge branch 'main' into rubocop-packs-dependency
technicalpickles Sep 20, 2023
01e9681
Add back rubocop as a dev dependency
technicalpickles Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 1 addition & 20 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ PATH
packwerk
parse_packwerk
rainbow
rubocop-packs
sorbet-runtime
thor
tty-prompt
Expand Down Expand Up @@ -125,7 +124,7 @@ GEM
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.12.0)
rspec-support (3.12.1)
rubocop (1.56.0)
rubocop (1.56.3)
base64 (~> 0.1.1)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
Expand All @@ -139,23 +138,6 @@ GEM
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.29.0)
parser (>= 3.2.1.0)
rubocop-capybara (2.18.0)
rubocop (~> 1.41)
rubocop-factory_bot (2.23.1)
rubocop (~> 1.33)
rubocop-packs (0.0.43)
activesupport
packs-specification
parse_packwerk
rubocop (~> 1.0)
rubocop-sorbet
sorbet-runtime
rubocop-rspec (2.23.2)
rubocop (~> 1.33)
rubocop-capybara (~> 2.17)
rubocop-factory_bot (~> 2.22)
rubocop-sorbet (0.7.3)
rubocop (>= 0.90.0)
ruby-progressbar (1.13.0)
smart_properties (1.17.0)
sorbet (0.5.10957)
Expand Down Expand Up @@ -223,7 +205,6 @@ DEPENDENCIES
rake
rspec (~> 3.0)
rubocop
rubocop-rspec
sorbet
sorbet-static
spoom (= 1.2.1)
Expand Down
1 change: 0 additions & 1 deletion lib/packs.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
require 'parse_packwerk'
require 'code_teams'
require 'code_ownership'
require 'rubocop-packs'

# Private implementation requires
require 'packs/private'
Expand Down
2 changes: 0 additions & 2 deletions packs.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ Gem::Specification.new do |spec|
spec.add_dependency 'packwerk'
spec.add_dependency 'parse_packwerk'
spec.add_dependency 'rainbow'
spec.add_dependency 'rubocop-packs'
spec.add_dependency 'sorbet-runtime'
spec.add_dependency 'thor'
spec.add_dependency 'tty-prompt'
Expand All @@ -45,7 +44,6 @@ Gem::Specification.new do |spec|
spec.add_development_dependency 'rake'
spec.add_development_dependency 'rspec', '~> 3.0'
spec.add_development_dependency 'rubocop'
spec.add_development_dependency 'rubocop-rspec'
spec.add_development_dependency 'sorbet'
spec.add_development_dependency 'sorbet-static'
spec.add_development_dependency 'spoom', '1.2.1' # later versions do not support ruby 2.7
Expand Down
Loading